Skip to content

[Simulation] add warnings if mapping in/out is out of the context - #6370

Merged
fredroy merged 3 commits into
sofa-framework:masterfrom
alxbilger:warningmappinggraph
Nov 5, 2026
Merged

[Simulation] add warnings if mapping in/out is out of the context#6370
fredroy merged 3 commits into
sofa-framework:masterfrom
alxbilger:warningmappinggraph

Conversation

@alxbilger

@alxbilger alxbilger commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Trigger warning if the input or the output of a mapping is out of the context of the mapping graph, i.e. not a child of the root node of the mapping graph.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code topic for next dev-meeting PR to be discussed in sofa-dev meeting labels Oct 9, 2026
@alxbilger alxbilger changed the title add warnings [Simulation] add warnings if mapping in/out is out of the context Oct 9, 2026
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request topic for next dev-meeting PR to be discussed in sofa-dev meeting labels Oct 15, 2026
hugtalbot
hugtalbot approved these changes Oct 15, 2026
View reviewed changes

@hugtalbot hugtalbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, shall we merge @alxbilger ?

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status ready Approved a pull-request, ready to be squashed labels Oct 15, 2026
@alxbilger

alxbilger commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

@hugtalbot Not yet, I'll plan to trigger this warning only once otherwise it triggers zillions of times by time step, and I'll extend it to more components.

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Oct 29, 2026
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Oct 29, 2026
@alxbilger
alxbilger force-pushed the warningmappinggraph branch from 40cf1c5 to b554f3a Compare October 29, 2026 15:46
@alxbilger
alxbilger requested a review from fredroy October 29, 2026 15:47
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 5, 2026
@fredroy
fredroy merged commit aa53c4f into sofa-framework:master Nov 5, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredroy fredroy fredroy approved these changes
@hugtalbot hugtalbot hugtalbot approved these changes
@bakpaul bakpaul bakpaul approved these changes

Assignees

No one assigned

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alxbilger @fredroy @hugtalbot @bakpaul